Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • EnPT EnPT
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 30
    • Issues 30
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • EnMAPEnMAP
  • GFZ_Tools_EnMAP_BOX
  • EnPTEnPT
  • Merge requests
  • !58

Enhance ACwater output

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Daniel Scheffler requested to merge feature/enhance_acwater_output into master Dec 14, 2021
  • Overview 63
  • Commits 64
  • Pipelines 47
  • Changes 22

This adds some additional layers computed in POLYMER AC to the output of EnPT.

Tasks to be done:

  • add additional parameters to the EnPT frontend to activate/deactivate the additional layers
    • adapt config files: config.py, options_default.json, options_schema.py
    • adapt command line argument parser(enpt_cli.py)
    • adapt GUI (enpt_enmapboxapp repository, here)
  • pass the new config parameters through to the atmospheric correction submodule
  • include new parameters in the call of ACwater
  • add additional output layers of ACwater to the EnPT-internal data model
  • adapt EnPT output writer to include the new output layers
  • write a software test that covers the new optional parameters (some include it here)
  • update the documentation and include the new ACwater output layers there (algorithm_descriptions.rst, probably about.rst, README.rst and maybe also something in tutorial.rst)
  • test and validate the outputs
  • add a version pinning for ACwater to avoid EnPT calls an old version of ACwater which does not implement the new layers yet (installation.rst)
  • add @leonardo.alvarado in AUTHORS.rst and setup.py and make sure the existing ICLA/CCLA covers him
  • update HISTORY.rst
Edited Feb 17, 2023 by Daniel Scheffler
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/enhance_acwater_output