Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • EnPT EnPT
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 24
    • Issues 24
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • EnMAPEnMAP
  • GFZ_Tools_EnMAP_BOX
  • EnPTEnPT
  • Merge requests
  • !54

Feature/separate ac land water

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Daniel Scheffler requested to merge feature/separate_ac_land_water into master Mar 16, 2021
  • Overview 82
  • Commits 63
  • Pipelines 26
  • Changes 19

This adds a separate atmospheric correction for water surfaces based on POLYMER.

Tasks to be solved before we can merge:

  • fix test_styles CI job (run make lint in the root dir of EnPT locally and check the logs)
  • implement acwater as optional requirement, i.e., auto-disable it if acwater + POLYMER is not installed
  • redirect water EnMAP pixels to acwater and land pixels to SICOR IF acwater + POLYMER is installed
  • combine atmospherically corrected results after running acwater and SICOR
  • evaluate range of output in combined mode
  • add all needed configuration parameter for acwater to config.py, options_default.json, options_schema.py
  • update the EnPT console argument parser (enpt_cli.py) with the now parameters needed for acwater
  • add documentation regarding acwater in installation.rst, algorithm_descriptions.rst, about.rst, README.rst and maybe also something in tutorial.rst
  • add @brenner.silva_at_awi.de in AUTHORS.rst as soon as ICLA/CCLA is signed
  • resolve all tasks and discussions in #47 (closed)
  • include acwater and POLYMER in the CI runner to make automated software tests work
  • provide software tests that cover acwater
  • validate EnPT L2A results over water areas

Closes #47 (closed).

@brenner.silva_at_awi.de @nbohn:
Lets develop this further in this merge request. Simply continue pushing to feature/separate_ac_land_water and check the above boxes as soon as these tasks are done.

Edited Jun 15, 2021 by Daniel Scheffler
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/separate_ac_land_water