Resolve "Create a rule that gets the construction date from cadaster data for Tabula dataset."

Closes #20 (closed)

\approve @ds @laurens @chengzhi

building/02_process/tabula/date_from_valencian_cadaster/date_from_valencian_cadaster.py

-# Copyright (c) 2023-2024:
+# Copyright (c) 2024:
 #   Helmholtz-Zentrum Potsdam Deutsches GeoForschungsZentrum GFZ
 #
 # This program is free software: you can redistribute it and/or modify it
@@ -13,11 +13,12 @@
 #
 # You should have received a copy of the GNU Affero General Public License
 # along with this program. If not, see http://www.gnu.org/licenses/.
-from databaselib import PostGISDatabase
+
 from rulelib import AbstractRule
 
 
 class DateFromValencianCadasterRule(AbstractRule):
+    from databaselib import PostGISDatabase
 
     def __call__(self, database: PostGISDatabase, geometry: str, *args, **kwargs):
         """
@@ -33,17 +34,18 @@ class DateFromValencianCadasterRule(AbstractRule):
                 Source database that contains the cadastral data, including the two necessary
                 tables `parcels` and `cadaster_buildings`.
             geometry (str):
-                Geometry of the building being currently processed.
+                Geometry of the building being currently processed. The geometry is a WKT
+                formatted string wrapped in the `ST_GeomFromText()` function.
 
         Returns:
-            Integer that represents the building's construction year.
+            Integer that represents the building's year of construction.
 
         """
 
         sql_statement = f"""
             SELECT construction_year
             FROM Parcels
-            INNER JOIN cadaster_buildings USING parcel_id
+            INNER JOIN cadaster_buildings USING(parcel_id)
             WHERE ST_Intersects({geometry}, Parcels.geom)
             """
         database.cursor.execute(sql_statement)