Skip to content
Snippets Groups Projects

Resolve "Change the processing of the `stories` rule to a `height` GEM Taxonomy tag"

Compare and Show latest version
3 files
+ 7
8
Compare changes
  • Side-by-side
  • Inline
Files
3
@@ -42,9 +42,7 @@ class HeightAndFloorspaceRule:
# to use that, we can also calculate the floorspace. The height tags in
# OSM are also parsed, but no floorspace is estimated.
try:
stories, floorspace = self.get_stories_and_floorspace_from_osm(
tags, area
)
stories, floorspace = self.get_stories_and_floorspace_from_osm(tags, area)
# OSM can have unexpected data types in their tagging scheme, therefore we do not raise
# an exception in case of a ValueError, but instead ignore the values.
except ValueError:
@@ -97,9 +95,7 @@ class HeightAndFloorspaceRule:
# Parse the story tags from OpenStreetMap.
main_stories = self.tag_to_float(tags, "building:levels")
roof_stories = self.tag_to_float(tags, "roof:levels")
underground_stories = self.tag_to_float(
tags, "building:levels:underground"
)
underground_stories = self.tag_to_float(tags, "building:levels:underground")
min_stories = self.tag_to_float(tags, "building:min_level")
# Parse the main stories and roof stories.
Loading