Skip to content
Snippets Groups Projects

Resolve "Fix the rulehandler to avoid running rules twice inside the `eval` function"

Merged Resolve "Fix the rulehandler to avoid running rules twice inside the `eval` function"
20-fix-the-rulehandler-to-avoid-running-rules-twice-inside-the-eval-function into main
All threads resolved!
Merged Pablo de la Mora requested to merge 20-fix-the-rulehandler-to-avoid-running-rules-twice-inside-the-eval-function into main
All threads resolved!

Closes #20 (closed)

\approve @ds @laurens @chengzhi

Edited by Pablo de la Mora

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Danijel Schorlemmer
  • Danijel Schorlemmer requested changes

    requested changes

  • Danijel Schorlemmer
    Danijel Schorlemmer @ds ·
    Owner

    Please clarify in the commit message what exactly has been done. Fixing something doesn't mean much if the problem or the solution is not mentioned.

  • Pablo de la Mora added 1 commit

    added 1 commit

    • 0f4c7416 - Fix rule dictionary update in eval function

    Compare with previous version

  • Danijel Schorlemmer resolved all threads

    resolved all threads

  • Pablo de la Mora added 1 commit

    added 1 commit

    • 94b6cea0 - Change rule handler to only update a rule when it has an output

    Compare with previous version

  • Pablo de la Mora assigned to @ds and unassigned @pdlmora

    assigned to @ds and unassigned @pdlmora

  • Danijel Schorlemmer approved this merge request

    approved this merge request

  • Danijel Schorlemmer assigned to @pdlmora and unassigned @ds

    assigned to @pdlmora and unassigned @ds

  • Pablo de la Mora merged

    merged

    • Please register or sign in to reply