Skip to content
Snippets Groups Projects

Add new setting REPLICATION_INTERVAL

Closed Lars Lingner requested to merge config/replication_interval into master
1 unresolved thread

This MR adds a new config option to set the REPLICATION_INTERVAL. The import option appendcache changed to overwritecache, because when running a new import an empty cache should be used.

\approve @fd

Merge request reports

Closed by Lars LingnerLars Lingner 2 years ago (Jun 28, 2022 2:42pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
86 86 -connection postgis://"${IMPOSM_DATABASE_URI}"/"${IMPOSM_DATABASE_NAME}" \
87 87 -srid 4326 \
88 88 -cachedir /var/cache/imposm/cache \
89 -diffdir /var/cache/imposm/diff
89 -diffdir /var/cache/imposm/diff \
90 -replication-interval "${IMPOSM_REPLICATION_INTERVAL}"
  • Please add this variable to the Globals in the comment for this function.

  • And what happens if this variable is not set? (haven't tested it) I think all others have somehow a check on them.

  • Good question, I haven't tested it. There might be a chance imposm falls back to the default value 1m0s but there might also be an error message.

    I'll update this MR.

    I don't see any checks of other variables.

  • All variables are within some if condition, like for example:

        if [[ -f "${IMPOSM_IMPORT_FILE}" ]]; then
  • Yes files can be checked this way. I was thinking about checking if any of these passed variables are set, that includes the IMPOSM_DATABASE_* variables. But now I think it is to much overhead. A proper solution would also include variable for all other parameter like SRID, DIFFDIR, ...

    I'll update the MR with checks and or default values for IMPOSM_IMPORT_STYLE and IMPOSM_REPLICATION_INTERVAL

  • Please register or sign in to reply
  • Felix Delattre assigned to @gislars and unassigned @fd

    assigned to @gislars and unassigned @fd

  • Lars Lingner added 1 commit

    added 1 commit

    • 7027cb2d - Add new config name REPLICATION_INTERVAL to comment section

    Compare with previous version

  • we don't want to change it anymore, closing it.

  • closed

  • Please register or sign in to reply
    Loading