obmgapanalysis issueshttps://git.gfz-potsdam.de/globaldynamicexposure/openbuildingmap/obmgapanalysis/-/issues2022-11-03T11:16:54+01:00https://git.gfz-potsdam.de/globaldynamicexposure/openbuildingmap/obmgapanalysis/-/issues/14The GHSL coverage per Quadtile needs to be recomputed after roads change2022-11-03T11:16:54+01:00Danijel SchorlemmerThe GHSL coverage per Quadtile needs to be recomputed after roads changeAfter roads are changed, the GHSL coverage should be recomputed. See an example of Quadtile 212102002022233210 in southern Argentina:
![image](/uploads/5da65db5673cd8c60d8ac8cbe810aec6/image.png)
In this area likely some buildings and ...After roads are changed, the GHSL coverage should be recomputed. See an example of Quadtile 212102002022233210 in southern Argentina:
![image](/uploads/5da65db5673cd8c60d8ac8cbe810aec6/image.png)
In this area likely some buildings and roads have been changed, triggering the completeness analysis to be recomputed. The unchanged GHSL polygon in the Quadtile shows a clear mismatch with the underlying roads. Given that we plan to have more features cutting out GHSL to reduce it to building area only (as far as possible), this issue should be tackled when the new procedure is in place.
\fyi @tara @shinde @gislarsBacklogLaurens OostwegelLaurens Oostwegelhttps://git.gfz-potsdam.de/globaldynamicexposure/openbuildingmap/obmgapanalysis/-/issues/13Deleting source_id 1 (source_id 3 is complete)2022-12-22T10:25:58+01:00Laurens OostwegelDeleting source_id 1 (source_id 3 is complete)We've calculated the whole world for GHSL data / roads using a different approach than ObmGapAnalysis. The result is the same, except the few bugs that were in ObmGapAnalysis (buffer of X meter had some reprojection error, therefore was ...We've calculated the whole world for GHSL data / roads using a different approach than ObmGapAnalysis. The result is the same, except the few bugs that were in ObmGapAnalysis (buffer of X meter had some reprojection error, therefore was not always X meter; tiles without any roads were missing in the database). As I didn't want to delete previous work in obm_tiles_dev, I used source_id 3 for this process. Now the whole world is completed, source_id 1 became redundant.
Because the dataset of source_id 1 contains bugs & is only covering a part of Europe, I'd like to delete it.
\rfc @cnievas can you give a go for deleting source_id 1? Or do you need it? To be clear: I am talking about the `obm_tiles_dev` database, not the `obm_tiles` database.https://git.gfz-potsdam.de/globaldynamicexposure/openbuildingmap/obmgapanalysis/-/issues/12GHSL misses two islands in azures2022-10-11T20:16:52+02:00Laurens OostwegelGHSL misses two islands in azuresSão Miguel (biggest island of the azures and most inhabitants) & Flores Island do - according to GHSL - have no built area at all. This is quite an issue, as these are also not really mapped in OSM either. Not sure how to continue with t...São Miguel (biggest island of the azures and most inhabitants) & Flores Island do - according to GHSL - have no built area at all. This is quite an issue, as these are also not really mapped in OSM either. Not sure how to continue with this.
\fyi @ds @shinde @tara @cnievashttps://git.gfz-potsdam.de/globaldynamicexposure/openbuildingmap/obmgapanalysis/-/issues/11BUG: ObmGapAnalysis does not add quadkeys where there are no roads2022-12-22T10:26:32+01:00Laurens OostwegelBUG: ObmGapAnalysis does not add quadkeys where there are no roadsBug is exactly like said in title: if there are no roads in `osm_replication`, the quadkey does not get added to the `built_area_assessments` table. This is actually quite a big problem, I expect that about ~2% of the quadkeys are missin...Bug is exactly like said in title: if there are no roads in `osm_replication`, the quadkey does not get added to the `built_area_assessments` table. This is actually quite a big problem, I expect that about ~2% of the quadkeys are missing.
See here a screenshot of Athens with the problems highlighted. Every single tile that is missing does not contain roads:
![image](/uploads/f7177b8cefd1007b483af84881300508/image.png)
\fyi @ds @tara @shinde @cnievashttps://git.gfz-potsdam.de/globaldynamicexposure/openbuildingmap/obmgapanalysis/-/issues/10Add Processor logic2021-05-10T11:07:37+02:00Nicolas Garcia OspinaAdd Processor logicInclude the Processor class with all its functions and documentation (Done in multiple MRs)
- [x] Define a proper initialization based on which dataset is used [!9](https://git.gfz-potsdam.de/dynamicexposure/openbuildingmap/obmgapanalys...Include the Processor class with all its functions and documentation (Done in multiple MRs)
- [x] Define a proper initialization based on which dataset is used [!9](https://git.gfz-potsdam.de/dynamicexposure/openbuildingmap/obmgapanalysis/-/merge_requests/9)
- [x] Initialize tiles based on quadkeys to not rely in precomputed grids [!7](https://git.gfz-potsdam.de/dynamicexposure/openbuildingmap/obmgapanalysis/-/merge_requests/7)
- [x] Include raster reading and subseting [!10](https://git.gfz-potsdam.de/dynamicexposure/openbuildingmap/obmgapanalysis/-/merge_requests/10)
- [x] Include raster vectorization [!11](https://git.gfz-potsdam.de/dynamicexposure/openbuildingmap/obmgapanalysis/-/merge_requests/11)
- [x] Include how to manage results (Generation of CSV files and COPY FROM statements) [!14](https://git.gfz-potsdam.de/dynamicexposure/openbuildingmap/obmgapanalysis/-/merge_requests/14)
- [x] Include processing of OBM data (requires Database class #8)
- [x] Manage data request (Roads/Buildings) !12
- [x] Process built-polygons with OBM dataNicolas Garcia OspinaNicolas Garcia Ospinahttps://git.gfz-potsdam.de/globaldynamicexposure/openbuildingmap/obmgapanalysis/-/issues/9Add Tile logic2021-06-11T07:54:51+02:00Felix DelattreAdd Tile logicInclude as a merge request the Tile class with appropriate attributes and descriptions.Include as a merge request the Tile class with appropriate attributes and descriptions.https://git.gfz-potsdam.de/globaldynamicexposure/openbuildingmap/obmgapanalysis/-/issues/8Add database logic2021-05-21T09:44:52+02:00Felix DelattreAdd database logicNicolas Garcia OspinaNicolas Garcia Ospinahttps://git.gfz-potsdam.de/globaldynamicexposure/openbuildingmap/obmgapanalysis/-/issues/7Add scripts2021-06-11T07:55:03+02:00Felix DelattreAdd scriptshttps://git.gfz-potsdam.de/globaldynamicexposure/openbuildingmap/obmgapanalysis/-/issues/6Define name for project2021-01-05T14:00:28+01:00Felix DelattreDefine name for projectLet's define together a name for this project. It should
* not contain an underscore or hyphen
* be unique (check on https://pypi.org/)
* suitable for the programLet's define together a name for this project. It should
* not contain an underscore or hyphen
* be unique (check on https://pypi.org/)
* suitable for the programhttps://git.gfz-potsdam.de/globaldynamicexposure/openbuildingmap/obmgapanalysis/-/issues/5Add very basic on structure2021-01-05T13:09:39+01:00Felix DelattreAdd very basic on structureThe python project structure can be improved by:
* Create a directory for project based on #6
* Add skeleton file
* A directory for the tests, including a first test file with a dummy test
* Add basic `setup.py`The python project structure can be improved by:
* Create a directory for project based on #6
* Add skeleton file
* A directory for the tests, including a first test file with a dummy test
* Add basic `setup.py`https://git.gfz-potsdam.de/globaldynamicexposure/openbuildingmap/obmgapanalysis/-/issues/4Add tests2021-06-11T07:54:58+02:00Felix DelattreAdd testsThere are some tests already in the repo. Let's review them together and bring them back in.There are some tests already in the repo. Let's review them together and bring them back in.https://git.gfz-potsdam.de/globaldynamicexposure/openbuildingmap/obmgapanalysis/-/issues/3Add copyright statements to code files2021-01-11T08:28:08+01:00Felix DelattreAdd copyright statements to code filesAll code files should have a short copyright statement at the beginning. You can check [betty](https://git.gfz-potsdam.de/dynamicexposure/coding/betty) for reference.All code files should have a short copyright statement at the beginning. You can check [betty](https://git.gfz-potsdam.de/dynamicexposure/coding/betty) for reference.https://git.gfz-potsdam.de/globaldynamicexposure/openbuildingmap/obmgapanalysis/-/issues/2Add code formatting2021-01-05T13:24:38+01:00Felix DelattreAdd code formattingYou can check [betty](https://git.gfz-potsdam.de/dynamicexposure/coding/betty) for reference.
In order to add code formatting and checking:
- Add the `Makefile` and adjust the directory and files it should check on
- Make sure the nece...You can check [betty](https://git.gfz-potsdam.de/dynamicexposure/coding/betty) for reference.
In order to add code formatting and checking:
- Add the `Makefile` and adjust the directory and files it should check on
- Make sure the necessary dependencies are in the `setup.py`
- Run `make black` and `make check` on your code and fix the errorshttps://git.gfz-potsdam.de/globaldynamicexposure/openbuildingmap/obmgapanalysis/-/issues/1Add CI pipeline to this repo2021-01-07T09:09:59+01:00Felix DelattreAdd CI pipeline to this repoI'd suggest to add a CI pipeline to this repo, as it can be found in [betty](https://gitext.gfz-potsdam.de/dynamicexposure/coding/betty). Happy to support/help out.
/cc @nicgarI'd suggest to add a CI pipeline to this repo, as it can be found in [betty](https://gitext.gfz-potsdam.de/dynamicexposure/coding/betty). Happy to support/help out.
/cc @nicgar