Check in GDE_check_tiles_vs_visual_CSVs.py inconsistent with decision in GDE_gather_SERA_and_OBM.py
In GDE_gather_SERA_and_OBM.py
, when the completeness file says that the cell/tile is water (code 5) or empty (code 6) but the code finds OBM buildings in the cell/tile, the completeness value is changed to code 3 (incomplete) but a value of 999 is assigned to the variable that is then used for the CSV visual output (https://git.gfz-potsdam.de/dynamicexposure/legacy/gde_calculations_prototype/-/blob/master/GDE_gather_SERA_and_OBM.py#L189). This 3 then gets written to the HDF5 GDE tiles, but a value of 999 is assigned to the same cell/tile in the visual CSV output by cell, with the purpose of indicating that there was an inconsistency. However, GDE_check_tiles_vs_visual_CSVs.py
checks that the completeness values reported in the HDF5 GDE tiles match those reported in the visual CSV output by cell and raise an error (https://git.gfz-potsdam.de/dynamicexposure/legacy/gde_calculations_prototype/-/blob/master/GDE_check_tiles_vs_visual_CSVs.py#L88). This means that the check in GDE_check_tiles_vs_visual_CSVs.py
is not consistent with what the code is doing (i.e. it is a badly designed check).