Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gde-importer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Dynamic Exposure
  • Global Dynamic Exposure
  • gde-importer
  • Merge requests
  • !5

Moved model-specific parameters from Configuration to ExposureModelESRM20

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Cecilia Nievas requested to merge changeconfig into master Jul 06, 2021
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 7

In !4 (comment 69192) we identified that we were moving forward in an inconsistent way regarding what was defined in the configuration file and became part of the Configuration class and what was being hard-coded within the ExposureModelESRM20 class. We have opted to hard-code the parameters that are properties of ESRM20 to the ExposureModelESRM20 class and thus eliminate the need for these parameters to be defined in the configuration file. This is because the user would need to know these parameters for ESRM20 to be able to run the code, i.e. there was no "free choice" of parameters possible. In other words, by indicating "esrm20" as the exposure_format in the configuration file, these parameters are implicit.

Due to this change, retrieve_exposure_entities is now being called from ExposureModelESRM20.__init__ and not AggregatedExposureModel.__init__, because it needs occupancy_cases to exist.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: changeconfig